Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failing GH-652 spec file on current master #2323

Closed
k77ch7 opened this issue Dec 15, 2014 · 2 comments
Closed

failing GH-652 spec file on current master #2323

k77ch7 opened this issue Dec 15, 2014 · 2 comments
Labels
beginner core JRuby 9000
Milestone
JRuby 9.0.0.0-pre1

Comments

@k77ch7
Copy link
Contributor

k77ch7 commented Dec 15, 2014

GH-652 spec file does not pass on current master. My UTC offset is +09:00.

On current master:

Command

jruby bin/rspec spec/regression/GH-652_time_add.rb

Results

Failures:

  1) time minus precision handles BC time correctly
     Failure/Error: (time - other_time).should eq(-63504988500.0)

       expected: -63504988500.0
            got: -63504994739.0

       (compared using ==)
     # ./spec/regression/GH-652_time_add.rb:14:in `(root)'

Finished in 0.072 seconds
2 examples, 1 failure

Failed examples:

rspec ./spec/regression/GH-652_time_add.rb:11 # time minus precision handles BC time correctly
@headius
Copy link
Member

headius commented Dec 15, 2014

Good report, thanks. These time-related ones are always a little tweaky across timezones.

@headius
Copy link
Member

headius commented Jan 16, 2015

This was actually a bad spec and failed for everyone. I forced it to use a specific offset.

@headius headius closed this as completed Jan 16, 2015
@headius headius added this to the JRuby 9.0.0.0-pre1 milestone Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner core JRuby 9000
Projects
None yet
Milestone
JRuby 9.0.0.0-pre1
Development

No branches or pull requests
2 participants
@headius @k77ch7