slab_allocator: fix leak of Persistent handles

nodejs · Jun 5, 2012 · 208d171 · 208d171
1 parent b9e40fb
commit 208d171
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/slab_allocator.cc b/src/slab_allocator.cc
@@ -49,10 +49,10 @@ SlabAllocator::SlabAllocator(unsigned int size) {
 
 SlabAllocator::~SlabAllocator() {
   if (!initialized_) return;
-  slab_sym_.Clear();
   slab_sym_.Dispose();
-  slab_.Clear();
+  slab_sym_.Clear();
   slab_.Dispose();
+  slab_.Clear();
 }
 
 
@@ -92,8 +92,8 @@ char* SlabAllocator::Allocate(Handle<Object> obj, unsigned int size) {
   }
 
   if (slab_.IsEmpty() || offset_ + size > size_) {
-    slab_.Clear();
     slab_.Dispose();
+    slab_.Clear();
     slab_ = Persistent<Object>::New(NewSlab(size_));
     offset_ = 0;
     last_ptr_ = NULL;