Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed concept of lock timout. Removed requirement for a Lock-Ticket t... #305

Closed
wants to merge 3 commits into from

Conversation

mikedurbin
Copy link
Contributor

...o delete a lock.

@@ -32,11 +31,10 @@
public class LockServiceImpl extends AbstractService implements LockService {

@Override
public Lock acquireLock(final Session session, final String path, long timeout, boolean deep)
public Lock acquireLock(final Session session, final String path, boolean deep)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not "final boolean deep"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arg... I need to get my IDE to help me catch this...

@awoods
Copy link

awoods commented Apr 18, 2014

Resolved with: 10e11e3

Addresses: https://www.pivotaltracker.com/story/show/69737940

@awoods awoods closed this Apr 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants