Make Enumerable#group_by compliant

opal · Nov 11, 2013 · 1c7a5e3 · 1c7a5e3
1 parent 570611d
commit 1c7a5e3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/opal/core/enumerable.rb b/opal/core/enumerable.rb
@@ -552,7 +552,7 @@ def grep(pattern, &block)
   def group_by(&block)
     return enum_for :group_by unless block_given?
 
-    hash = Hash.new { |h, k| h[k] = [] }
+    hash = Hash.new
 
     %x{
       var result;
@@ -566,7 +566,7 @@ def group_by(&block)
           return $breaker;
         }
 
-        #{hash[`value`] << `param`};
+        #{(hash[`value`] ||= []) << `param`};
       }
 
       self.$each();

diff --git a/spec/filters/bugs/enumerable.rb b/spec/filters/bugs/enumerable.rb
@@ -3,9 +3,6 @@
 
   fails "Enumerable#grep can use $~ in the block when used with a Regexp"
 
-  fails "Enumerable#group_by returns a hash without default_proc"
-  fails "Enumerable#group_by gathers whole arrays as elements when each yields multiple"
-
   fails "Enumerable#inject returns nil when fails(legacy rubycon)"
   fails "Enumerable#inject without inject arguments(legacy rubycon)"