Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dump could deal the encoding #25

Merged
merged 2 commits into from May 10, 2014

Conversation

keedi
Copy link
Contributor

@keedi keedi commented May 9, 2014

Current version of galileo dump command cannot dump the utf-8 encoded pages like snowflake properly. (Of course utf-8 encoded CJK characters cannot be dumped to file.) This patch adds --encoding or -e options for dump command. By default it does nothing like original code. But if someone have trouble with dump due to utf-8 encoded characters then --encoding=utf-8 option could help.

I've just tested under default SQLite database (as Galileo default setting) and it just works. And added document is very shoddy so please consider that. :)

@jberger
Copy link
Owner

jberger commented May 10, 2014

Wow, thanks for the pr and the tests too! I might make a couple tweaks here and there, but this is an example of an outstanding pr!

jberger added a commit that referenced this pull request May 10, 2014
@jberger jberger merged commit b2d8f40 into jberger:master May 10, 2014
@jberger
Copy link
Owner

jberger commented May 10, 2014

Released as version 0.033 to CPAN. Thanks again!

@jberger
Copy link
Owner

jberger commented May 10, 2014

Btw I also made the dump output UTF-8 by default

@keedi keedi deleted the feature/support-dump-encoding branch May 12, 2014 06:44
@keedi
Copy link
Contributor Author

keedi commented May 12, 2014

Thanks for fast release. Now page dump works well with my CJK utf-8 characters. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants