Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups #456

Merged
merged 3 commits into from May 25, 2013
Merged

Cleanups #456

merged 3 commits into from May 25, 2013

Conversation

norv
Copy link
Contributor

@norv norv commented May 25, 2013

A few refactorings.

  • took in @joshuaadickerson findings in Participation #427 controllers using topics participation.
  • reworked messagesSince() and countMessagesSince() to be consistent. They are working on the same thing, just one does count, the other gets the messages ids. Updated them to be more reusable, both now accept $only_approved, and a switch to include the (current) message in the result. ($include_current)

joshuaadickerson and others added 3 commits May 25, 2013 22:23
@joshuaadickerson @norv
Commit refactoring of Recent controller using the topicsParticipation…
04e5533 
…() function.

Signed-off-by: Norv <a.w.norv@gmail.com>
@joshuaadickerson @norv
Add topics participation to search controller as well.
91e69f6 
Signed-off-by: Norv <a.w.norv@gmail.com>
@norv
Update subs functions for more consistency: messagesSince() and count…
c74bf03 
…MessagesSince().

Signed-off-by: Norv <a.w.norv@gmail.com>
norv added a commit that referenced this pull request May 25, 2013
@norv
Merge pull request #456 from norv/cleanups
5aa053f 
Cleanups
@norv norv merged commit 5aa053f into elkarte:master May 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@norv @joshuaadickerson