Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.

Commit

Permalink
travis: debug gethostbyname test, take 3
Browse files Browse the repository at this point in the history
  • Loading branch information
bnoordhuis committed Jul 1, 2012
1 parent 0f7cb61 commit 4b2e7c7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/test-gethostbyname.c
Expand Up @@ -145,7 +145,6 @@ TEST_IMPL(gethostbyname) {
printf("Start gethostbyname and gethostbyaddr concurrent test\n");
setup_cares();

#if 0
ares_bynamecallbacks = 0;
bynamecallbacksig = 7;

Expand All @@ -154,8 +153,8 @@ TEST_IMPL(gethostbyname) {
AF_INET,
&aresbynamecallback,
&bynamecallbacksig);
#endif

#if 0
ares_byaddrcallbacks = 0;
byaddrcallbacksig = 8;
addr[0] = 10;
Expand All @@ -169,11 +168,12 @@ TEST_IMPL(gethostbyname) {
AF_INET,
&aresbyaddrcallback,
&byaddrcallbacksig);
#endif

uv_run(uv_default_loop());

/* ASSERT(ares_bynamecallbacks == 1); */
ASSERT(ares_byaddrcallbacks == 1);
ASSERT(ares_bynamecallbacks == 1);
/* ASSERT(ares_byaddrcallbacks == 1); */


uv_ares_destroy(uv_default_loop(), channel);
Expand Down

2 comments on commit 4b2e7c7

@piscisaureus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnoordhuis I think travis doesn't like this test because UDP is somehow not working. You should try and force cares to use TCP (ARES_FLAG_VC or something like that)

@bnoordhuis
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmalecki See above. Could that be the issue?

Please sign in to comment.