Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal-browser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 297750ba5c5f
Choose a base ref
...
head repository: opal/opal-browser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cba801ad553f
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Feb 6, 2014

  1. dom/attribute: polyfill #id?

    @meh
    meh committed Feb 6, 2014
    Copy the full SHA
    abed806 View commit details

  2. spec/runner: cleanup the job order

    @meh
    meh committed Feb 6, 2014
    Copy the full SHA
    cba801a View commit details
Showing with 19 additions and 7 deletions.
  1. +4 −6 .travis.yml
  2. +7 −1 opal/browser/dom/attribute.rb
  3. +8 −0 opal/browser/support.rb
10 changes: 4 additions & 6 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -26,6 +26,10 @@ env:
- SELENIUM_BROWSER=ie SELENIUM_VERSION=10
- SELENIUM_BROWSER=ie SELENIUM_VERSION=11

- SELENIUM_BROWSER=safari SELENIUM_VERSION=5.1
- SELENIUM_BROWSER=safari SELENIUM_VERSION=6.1
- SELENIUM_BROWSER=safari SELENIUM_VERSION=7.0

- SELENIUM_BROWSER=ipad SELENIUM_DEVICE="iPad 2 (5.0)"
- SELENIUM_BROWSER=iphone SELENIUM_DEVICE="iPhone 4S"
- SELENIUM_BROWSER=iphone SELENIUM_DEVICE="iPhone 5"
@@ -35,10 +39,6 @@ env:
- SELENIUM_BROWSER=android SELENIUM_DEVICE="Motorola Razr Maxx HD"
- SELENIUM_BROWSER=android SELENIUM_DEVICE="LG Nexus 4"

- SELENIUM_BROWSER=safari SELENIUM_VERSION=5.1
- SELENIUM_BROWSER=safari SELENIUM_VERSION=6.1
- SELENIUM_BROWSER=safari SELENIUM_VERSION=7.0

- SELENIUM_BROWSER=chrome SELENIUM_VERSION=30
- SELENIUM_BROWSER=chrome SELENIUM_VERSION=31

@@ -50,9 +50,7 @@ matrix:

# Mobile?
- env: SELENIUM_BROWSER=ipad SELENIUM_DEVICE="iPad 2 (5.0)"
- env: SELENIUM_BROWSER=iphone SELENIUM_DEVICE="iPhone 4S"
- env: SELENIUM_BROWSER=iphone SELENIUM_DEVICE="iPhone 5"
- env: SELENIUM_BROWSER=iphone SELENIUM_DEVICE="iPhone 5S"

- env: SELENIUM_BROWSER=android SELENIUM_DEVICE="Samsung Galaxy Nexus"
- env: SELENIUM_BROWSER=android SELENIUM_DEVICE="Motorola Razr Maxx HD"
8 changes: 7 additions & 1 deletion opal/browser/dom/attribute.rb
View file
Original file line number Diff line number Diff line change
@@ -14,7 +14,13 @@ class Attribute
alias_native :value=

# Returns true if the attribute is an id.
alias_native :id?, :isId
if Browser.supports? 'Attr.isId'
alias_native :id?, :isId
else
def id?
name == :id
end
end
end

end; end
8 changes: 8 additions & 0 deletions opal/browser/support.rb
View file
Original file line number Diff line number Diff line change
@@ -101,6 +101,14 @@ def self.supports?(feature)
when 'Window.pageOffset'
defined?(`window.pageXOffset`)

when 'Attr.isId'
%x{
var div = document.createElement('div')
div.setAttribute('id', 'xxxxxxxxxxxxx');
return typeof(div.attributes.item('id').isId) !== "undefined";
}

when 'Element.addBehavior'
defined?(`document.documentElement.addBehavior`)