Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: e772a7deaf8e
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: f878376c83e0
Choose a head ref
  • 7 commits
  • 2 files changed
  • 1 contributor

Commits on Aug 2, 2013

  1. build: switch configure to argparse

    The optparse module is deprecated and possibly unmaintained. Switch to
    argparse.
    bnoordhuis committed Aug 2, 2013
    Copy the full SHA
    d28793a View commit details
    Browse the repository at this point in the history
  2. build: order configure switches alphabetically

    Put switches in alphabetical order but keep --prefix at the top because
    that's arguably the one people will be looking for most.
    bnoordhuis committed Aug 2, 2013
    Copy the full SHA
    5e5e530 View commit details
    Browse the repository at this point in the history
  3. build: fix up style issues in configure script

    * Use single quotes consistently.
    * Remove a few stray semicolons.
    * Fix up some overly long lines.
    * Line up a few expressions.
    bnoordhuis committed Aug 2, 2013
    Copy the full SHA
    5890fc4 View commit details
    Browse the repository at this point in the history
  4. build: use advanced argparse options in configure

    * Set up defaults for configure switches that have, well, defaults.
    * Set up choices for configure switches that are multiple choice.
    bnoordhuis committed Aug 2, 2013
    Copy the full SHA
    07a6596 View commit details
    Browse the repository at this point in the history
  5. build: improve ninja build, don't run configure

    * The way the ninja build was configured triggered a lot of unnecessary
      rebuilds due to unconditionally touching out/Makefile. Said file is
      not used by ninja anyway so rewrite the rules to factor it out.
    
    * The misfeature of running ./configure when the configure script has
      been touched has been removed - it destroys the existing configuration
      at the most inopportune times. Instead, print an error message telling
      the user to (re-)run ./configure.
    
    * Speed up null builds by not invoking `ninja` when there is nothing to
      do.
    
    * Remove cruft from the Makefile. Eliminate a few .PHONY targets, etc.
    bnoordhuis committed Aug 2, 2013
    Copy the full SHA
    675e105 View commit details
    Browse the repository at this point in the history
  6. build: make ninja build respect V=

    Compiling with `make V=1` (which is the default, actually) now runs
    ninja in verbose mode. To disable, run `make V=`.
    bnoordhuis committed Aug 2, 2013
    Copy the full SHA
    f7b2572 View commit details
    Browse the repository at this point in the history
  7. configure: lowercase configure switch descriptions

    Purely an aesthetic change but the help messages are a little more
    distinct from the switch argument(s) now.
    bnoordhuis committed Aug 2, 2013
    Copy the full SHA
    f878376 View commit details
    Browse the repository at this point in the history