Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 681013223f92
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 6f952845a6b2
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on May 23, 2014

  1. src: kill isolate on exit 

    Otherwise it's not possible to check from inside a destructor if V8 is
still alive with v8::V8::IsDead().  In V8 3.25, that function returns
true until the last isolate is destroyed.

This used to work in v0.10 and is a standard trick to dispose persistent
handles conditionally.

Signed-off-by: Fedor Indutny <fedor@indutny.com>
    @bnoordhuis @indutny
    bnoordhuis authored and indutny committed May 23, 2014
    Copy the full SHA
    6f95284 View commit details
    Browse the repository at this point in the history