Skip to content

Commit

Permalink
[fix] Don't localize runlist
Browse files Browse the repository at this point in the history
Localizing runlist caused weird behavior, for example:

  1. Template was changed and system was published
  2. `quill configure <system>` was ran
  3. File was templated but `configure` script wasn't ran
  • Loading branch information
mmalecki committed Aug 8, 2013
1 parent 429798e commit 7079052
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 105 deletions.
10 changes: 1 addition & 9 deletions lib/quill/composer/lifecycle.js
Expand Up @@ -271,15 +271,7 @@ exports.run = function (action, systems, callback) {
//
function installSystem(runlist, done) {
async.waterfall([
async.apply(composer.installed.list),
function maybeLocalizeRunlist(installed_, next) {
installed = installed_;

return /^install/.test(action) && quill.argv.force
? next(null, runlist)
: next(null, composer.runlist.localize(runlist, installed, quill.log));
},
function installExternalDeps(runlist, next) {
function installExternalDeps(next) {
wtfpm(function (err, managers) {
if (err) {
return next(err);
Expand Down
6 changes: 3 additions & 3 deletions test/commands/systems-test.js
Expand Up @@ -209,9 +209,9 @@ vows.describe('quill/commands/systems').addBatch({
'should install the latest version',
function (err, _) {
assert.isNull(err);
assert.lengthOf(this.data, 1);
assert.equal(this.data[0].name, 'hello-world');
assert.equal(this.data[0].data, '0.1.0\n');
assert.lengthOf(this.data, 7);
assert.equal(this.data[this.data.length - 1].name, 'hello-world');
assert.equal(this.data[this.data.length - 1].data, '0.1.0\n');
}
)
}
Expand Down
93 changes: 0 additions & 93 deletions test/composer/lifecycle-reinstall-test.js

This file was deleted.

0 comments on commit 7079052

Please sign in to comment.