Fix #3058 querystring: Fix incorrect handling of empty keys

nodejs · May 11, 2012 · a811a4a · a811a4a
1 parent 12fc9fa
commit a811a4a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/querystring.js b/lib/querystring.js
@@ -189,6 +189,11 @@ QueryString.parse = QueryString.decode = function(qs, sep, eq, options) {
         kstr = x.substring(0, idx),
         vstr = x.substring(idx + 1), k, v;
 
+    if (kstr === '' && vstr !== '') {
+      kstr = vstr;
+      vstr = '';
+    }
+
     try {
       k = decodeURIComponent(kstr);
       v = decodeURIComponent(vstr);

diff --git a/test/simple/test-querystring.js b/test/simple/test-querystring.js
@@ -55,7 +55,9 @@ var qsTestCases = [
     { hasOwnProperty: 'x',
       toString: 'foo',
       valueOf: 'bar',
-      __defineGetter__: 'baz' }]
+      __defineGetter__: 'baz' }],
+  // See: https://github.com/joyent/node/issues/3058
+  ['foo&bar=baz', 'foo=&bar=baz', { foo: '', bar: 'baz' }]
 ];
 
 // [ wonkyQS, canonicalQS, obj ]