Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please lift the restriction on semigroups 0.12 #25

Closed
peti opened this issue Nov 27, 2013 · 4 comments
Closed

Please lift the restriction on semigroups 0.12 #25

peti opened this issue Nov 27, 2013 · 4 comments

Comments

@peti
Copy link

peti commented Nov 27, 2013

Your package compiles fine with the latest version of semigroups after the restrictions in the Cabal file have been lifted.

@bergey
Copy link
Member

bergey commented Nov 27, 2013

I can confirm that cabal install core/ lib/ contrib/ svg/ -j --constraint=semigroups==0.12 dual-tree/ monoid-extras/ active/ works, after bumping the semigroups constraints on all 6 packages. (svg doesn't actually have a semigroups dependency.)

It looks as though semigroups-0.12 is all additions, no API changes.

@byorgey Is it OK if I just push these to the respective master branches?

@byorgey
Copy link
Member

byorgey commented Nov 27, 2013

Yes, it looks like semigroups-0.12 adds a class instance for Const, which according to the PVP requires a major version bump (because it breaks any code which had declared an orphan instance). But it shouldn't affect us since we don't have an orphan instance for Const. Go ahead and push, and I'll put out some minor releases (I have a script for doing the process quickly).

@bergey
Copy link
Member

bergey commented Nov 27, 2013

Done. Thanks for the explanation about the orphan instance issue; I did not understand that before.

@bergey bergey closed this as completed Nov 27, 2013
@byorgey
Copy link
Member

byorgey commented Nov 28, 2013

Released monoid-extras-0.3.2.4, dual-tree-0.2.0.1, active-0.1.0.10, diagrams-core-1.0.0.1, diagrams-lib-1.0.0.1, and diagrams-contrib-1.0.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants