Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rustyrussell/pettycoin
base: ed62a32f985a
Choose a base ref
...
head repository: rustyrussell/pettycoin
compare: d9a5640ee0e1
Choose a head ref
  • 13 commits
  • 76 files changed
  • 1 contributor

Commits on Aug 27, 2014

  1. tools: fix update-ccan.sh 

    We need to ignore ccan/Makefile.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 27, 2014
    Configuration menu
    Copy the full SHA
    8bee460 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2014

  1. ccan: update 

    In particular, I saw an assert() in ccan/io.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    b4c4bce View commit details
    Browse the repository at this point in the history

  2. peer: remove welcome_blocks. 

    We we only need it within welcome_received().

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    c81e2aa View commit details
    Browse the repository at this point in the history

  3. protocol: remove block_find(). 

    An old relic, unused.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    cc95605 View commit details
    Browse the repository at this point in the history

  4. test/easygenesis.c: generate automatically. 

    We can generate it, so we should.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    dd588b3 View commit details
    Browse the repository at this point in the history

  5. protocol: clean up header comments. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    6315dcc View commit details
    Browse the repository at this point in the history

  6. cleanup: make an explicit protocol_block_id and protocol_tx_id types. 

    They're just normal double SHAs, but it's a bit more typesafe.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    e18ec40 View commit details
    Browse the repository at this point in the history

  7. json, logging, packet: add helpers for protocol_block_id/protocol_tx_id 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    6b56723 View commit details
    Browse the repository at this point in the history

  8. protocol: use the protocol_block_id type. 

    No changes on the wire.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    4aec084 View commit details
    Browse the repository at this point in the history

  9. check_block: make sure difficulty value is valid. 

    This becomes more important as we start keeping blocks where we don't
know all the ancestors, hence don't immediately validate difficulty.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    72ff829 View commit details
    Browse the repository at this point in the history

  10. peer: don't log connection until after we've checked for dups. 

    This happens a lot during testing, and it's confusing.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    cef65d5 View commit details
    Browse the repository at this point in the history

  11. log: don't call strlen on LOG_IO buffers. 

    As found by valgrind.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    2a6a111 View commit details
    Browse the repository at this point in the history

  12. pettycoin-generate: quit as soon as stdin closes. 

    I noticed that I was getting:

	pettycoin-generate: ''I'm not trying to cause a b-big s-s-sensation'': Broken pipe

Which can happen if pettycoin-generate is supposed to close *just* as
it is writing the solution, but should be extremely rare.

In practice, it was ignoring the zero reads from stdin, which it shouldn't;
it should ignore EWOULDBLOCK.  I renamed the function and didn't use it
where unnecessary, for increased clarity.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 29, 2014
    Configuration menu
    Copy the full SHA
    d9a5640 View commit details
    Browse the repository at this point in the history