Basic Subs fixes (from http://www.elkarte.net/index.php?topic=475.0) #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-------------------------------------------------------------------- Line 1255: Add wmode transparent to flash embed code. This stops embedded flash hiding any drop menus. Google "flash hides drop menus" if you want to check it out. Line 1296+: Change glow tag to W3C only. Also changed offset and blur radius so it is now different to the shadow tag (was the same). Note that the new code as echoed to the browser isn't quite right. Still needs tweaking by someone who knows funny sources stuff. Echoes (glow=red,2,300) by default. Should just echo (glow=red). Line 1463+: Dropped superfluous divs from quote tags. Line 1532+: Change shadow tag to W3C only. Line 1803: Comment for @todo list. Line 2065+: More comments for @todo. Worthwhile ideas, IMO. Line 3165: Another @todo, re existing inline CSS for copyright. Line 3205+: Notes for more @todo stuff (lotsa deprecated shiz). Line 3296: Just another @todo for something which would be handy. Signed-off-by:ichbin <ichbin@ichbin.us>
|
Just to save possible confusion, I made a typo in the readme. That last addition is actually on Line 3926. Not worth amending the PR for it. Just thought I'd let people know. 😄 |
| @@ -17,7 +17,7 @@ | |||
| * | |||
| */ | |||
|
|
|||
| if (!defined('ELK')) | |||
| if (!defined('ELKARTE')) | |||
There was a problem hiding this comment.
attention ;) Seems the file was based on an earlier version.
|
Thank you! |
|
Ignore that last one. I seem to have gone and commented in the wrong place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 1255: Add wmode transparent to flash embed code.
This stops embedded flash hiding any drop menus.
Google "flash hides drop menus" if you want to check it out.
Line 1296+: Change glow tag to W3C only. Also changed offset and blur radius
so it is now different to the shadow tag (was the same).
Note that the new code as echoed to the browser isn't quite right.
Still needs tweaking by someone who knows funny sources stuff.
Echoes (glow=red,2,300) by default. Should just echo (glow=red).
Line 1463+: Dropped superfluous divs from quote tags.
Line 1532+: Change shadow tag to W3C only.
Line 1803: Comment for @todo list.
Line 2065+: More comments for @todo. Worthwhile ideas, IMO.
Line 3165: Another @todo, re existing inline CSS for copyright.
Line 3205+: Notes for more @todo stuff (lotsa deprecated shiz).
Line 3296: Just another @todo for something which would be handy.
Signed-off-by:ichbin ichbin@ichbin.us