This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.

...

2 commits
8 files changed
1 contributor

Commits on Mar 14, 2013

deps: upgrade libuv to 7b66ea1

bnoordhuis committed Mar 14, 2013

Copy the full SHA

e99dff4 View commit details

Browse the repository at this point in the history

net: improve arbitrary tcp socket support

Consider this example:

  // fd 3 is a bound tcp socket
  var s = net.createServer(cb);
  s.listen({ fd: 3 });
  console.log(s.address());  // prints null

This commit makes net.Server#address() print the actual address.

Ditto for non-listen sockets; properties like net.Socket#localAddress
and net.Socket#remoteAddress now return the correct value.

Fixes #5009.

bnoordhuis committed Mar 14, 2013