tls: localhost is valid against identity-check

nodejs · Jul 20, 2012 · 0cf2354 · 0cf2354
1 parent 8ba189b
commit 0cf2354
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/lib/tls.js b/lib/tls.js
@@ -85,10 +85,6 @@ function checkServerIdentity(host, cert) {
     // Add trailing dot (make hostnames uniform)
     if (!/\.$/.test(host)) host += '.';
 
-    // Host names with less than one dots are considered too broad,
-    // and should not be allowed
-    if (!/^.+\..+$/.test(host)) return /$./;
-
     // The same applies to hostname with more than one wildcard,
     // if hostname has wildcard when wildcards are not allowed,
     // or if there are less than two dots after wildcard (i.e. *.com or *d.com)

diff --git a/test/simple/test-tls-check-server-identity.js b/test/simple/test-tls-check-server-identity.js
@@ -180,6 +180,13 @@ var tests = [
     },
     result: false
   },
+  {
+    host: 'localhost', cert: {
+      subjectaltname: 'DNS:a.com',
+      subject: { CN: 'localhost' }
+    },
+    result: true
+  },
 ];
 
 tests.forEach(function(test, i) {