Ryddesc #31
Ryddesc #31
Conversation
never verified to work in the original study
|
I saw a talk by Martin Šícho yesterday who has been woking on similar descriptors to Patriks FAME 2 and even update SMARTcyp I believe. Anyways, still using the CDK so going to drop a message and see if he would like to take a look at this PR. |
|
In fact I've actually looked at these commits, and there's not really anything to review. Just need to check the final one I guess... others are just maintaince. Could still get Martin to push his new descriptors back to CDK which would be good. |
|
I am sorry to inform you that Patrik Rydberg -my husband passed away 29th
of november 2013 so he cannot read your emails any longer
sorry you did not know.
kind regards his widow Kim
…On Thu, Feb 15, 2018 at 11:02 AM, John Mayfield ***@***.***> wrote:
In fact I've actually looked at these commits, and there's not really
anything to review. Just need to check the final one I guess... others are
just maintaince. Could still get Martin to push his new descriptors back to
CDK which would be good.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ACGEfHBg-nV-ifiMGP7oqJCX9QBo8S9_ks5tVACrgaJpZM4AfVaY>
.
--
------------------------------
Patrik Rydberg
Phone: +44 (0)7463 468141
|
|
Hi Kim, We both knew Patrik and are sorry for your loss then and now. Please feel free to unsubscribe from notifications on this thread (button on the right). My additional comments these many years later are because I knew this was still open and heard a talk last week by Martin Šícho that built upon Patrik's work. Kind Regards, |
|
Dear Kim, first, my condolences (my relation with Patrik was that of a collaborator, and unfortunately I did not know how to reach you at the time). The loss of Patrik did most certainly not go unnoticed, neither did his contributions to our field. The latter causes me to regularly think back about Patrik, in fact, just yesterday when a project he started (with @vedina and @olas) and I have been able to contribute to came up at a research conference. This issue report is a reminder to make sure his contributions are not lost. I second John's comments about unsubscribing. My best wishes and regards, Egon |
|
I have not been able to remove him from all acounts because I did not know
all his work accounts that he belonged to.
I check his email sometimes if some come up that I should unsubscribe from.
I miss him so much and it is hard to just delete him from everything. It
is just too hard to do.
there was so much of his work that I was not aware of how much he
contributed in his field.
I hope there is someone who can take on the work he started on the p450
computational programs he did.
I just wish he was here today.
…On Thu, Feb 22, 2018 at 7:49 AM, Egon Willighagen ***@***.***> wrote:
Dear Kim,
first, my condolences (my relation with Patrik was that of a collaborator,
and unfortunately I did not know how to reach you at the time).
The loss of Patrik did most certainly not go unnoticed, neither did his
contributions to our field. The latter causes me to regularly think back
about Patrik, in fact, just yesterday when a project he started (with
@vedina <https://github.com/vedina> and @olas <https://github.com/olas>)
and I have been able to contribute to came up at a research conference.
This issue report is a reminder to make sure his contributions are not
lost. I second John's comments about unsubscribing.
My best wishes and regards,
Egon
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ACGEfAGFelfkKguxCPunJ11hSdSJ9DbIks5tXQ3-gaJpZM4AfVaY>
.
--
------------------------------
Patrik Rydberg
Phone: +44 (0)7463 468141
|
|
This pull request was created nine years ago. |
|
it was indeed. There are still some useful bits of CDK extension that has not been ported yet :/ |
|
@egonw last time I looked the vast majority was now included just hard to see as not rebased, so I would close it. Please let me know which part is missing and we can pull it in |
added reference to paper describing the descriptors, and a general description of the descriptors to the javadoc section of the file.
I hope this was done in the correct manner, since it's my first time, please check that it looks ok.