Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration test confirming nodetype inheritance #251

Closed
wants to merge 3 commits into from

Conversation

yulgit1
Copy link
Contributor

@yulgit1 yulgit1 commented Feb 19, 2014

using test a nodetype test:testInher with indexing:indexable as supertype

https://www.pivotaltracker.com/s/projects/684825/stories/65151184

@ajs6f
Copy link
Contributor

ajs6f commented Feb 19, 2014

Maybe squash the clean up commit? I know that would make @awoods happy.

@ajs6f
Copy link
Contributor

ajs6f commented Feb 19, 2014

Whoa! Hang on! Why is this test showing up in the core codebase and not in the indexer codebase?

@yulgit1
Copy link
Contributor Author

yulgit1 commented Feb 19, 2014

I put it in FedoraResourceImplIT as what it's really testing is the code in NodeRDFContext creating RDF for a fedora resource - specificly that adding a mixin (with a supertype) to an object will show that supertype as one of its own rdf:types. It just happens to be using indexing:indexable as that supertype.

@ajs6f
Copy link
Contributor

ajs6f commented Feb 19, 2014

Okay, but then, just to be clear, how about changing the types involved to something not obviously related to indexing, like "dummytype" and "dummysupertype" or the like? Reusing the indexing vocabulary is liable to confuse people-- it confused me.

@yulgit1
Copy link
Contributor Author

yulgit1 commented Feb 19, 2014

sure, would a comment to the effect of "confirming the types of a supertype are inherited, using the real use case of indexing:indexable" suffice?

@ajs6f
Copy link
Contributor

ajs6f commented Feb 19, 2014

I would really prefer to use an independent nomenclature. I know it's a bit of work, and if you're caught up with other things, I can send a PR for this PR to do it. I really want to keep indexing's nose out of the core codebase.

@yulgit1
Copy link
Contributor Author

yulgit1 commented Feb 19, 2014

ok

@yulgit1 yulgit1 closed this Feb 19, 2014
@yulgit1 yulgit1 reopened this Feb 19, 2014
@awoods
Copy link

awoods commented Feb 21, 2014

Resolved with: 14eb8b3

Addresses: https://www.pivotaltracker.com/story/show/65151184

@awoods awoods closed this Feb 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants