Send email notifications when updating bugs using the SOAP API

rombert · rombert · commit 268f72af76a2 · 2011-09-23T00:01:47.000+03:00
Fix #13339 : Email notifications through mantis mylyn connector / SOAP
diff --git a/api/soap/mc_issue_api.php b/api/soap/mc_issue_api.php
@@ -807,10 +807,6 @@ function mc_issue_update( $p_username, $p_password, $p_issue_id, $p_issue ) {
 		$t_bug_data->target_version = isset( $p_issue['target_version'] ) ? $p_issue['target_version'] : '';
 	}
 
-
-	# submit the issue
-	$t_is_success = $t_bug_data->update( /* update_extended */ true, /* bypass_email */ true );
-	
 	mci_issue_set_custom_fields( $p_issue_id, $p_issue['custom_fields'], true );
 	if ( isset ( $p_issue['monitors'] ) )
 	    mci_issue_set_monitors( $p_issue_id , $t_user_id, $p_issue['monitors'] );
@@ -831,7 +827,6 @@ function mc_issue_update( $p_username, $p_password, $p_issue_id, $p_issue ) {
 				if ( bugnote_exists( $t_bugnote_id ) ) {
 					bugnote_set_text( $t_bugnote_id, $t_note['text'] );
 					bugnote_set_view_state( $t_bugnote_id, $t_view_state_id == VS_PRIVATE );
-	$t_eta_id = isset( $p_issue['eta'] ) ? mci_get_eta_id( $p_issue['eta'] ) : config_get('default_bug_eta');
 					bugnote_date_update( $t_bugnote_id );
 					if ( isset( $t_note['time_tracking'] ) )
 						bugnote_set_time_tracking( $t_bugnote_id, mci_get_time_tracking_from_note( $p_issue_id, $t_note ) );
@@ -846,8 +841,9 @@ function mc_issue_update( $p_username, $p_password, $p_issue_id, $p_issue ) {
 			}
 		}
 	}
-
-	return $t_is_success;
+	
+	# submit the issue
+	return $t_is_success = $t_bug_data->update( /* update_extended */ true, /* bypass_email */ false);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -807,10 +807,6 @@ function mc_issue_update( $p_username, $p_password, $p_issue_id, $p_issue ) {`
`807`	`807`	`$t_bug_data->target_version = isset( $p_issue['target_version'] ) ? $p_issue['target_version'] : '';`
`808`	`808`	`}`
`809`	`809`
`810`		`-`
`811`		`- # submit the issue`
`812`		`- $t_is_success = $t_bug_data->update( /* update_extended / true, / bypass_email */ true );`
`813`		`-`
`814`	`810`	`mci_issue_set_custom_fields( $p_issue_id, $p_issue['custom_fields'], true );`
`815`	`811`	`if ( isset ( $p_issue['monitors'] ) )`
`816`	`812`	`mci_issue_set_monitors( $p_issue_id , $t_user_id, $p_issue['monitors'] );`
`@@ -831,7 +827,6 @@ function mc_issue_update( $p_username, $p_password, $p_issue_id, $p_issue ) {`
`831`	`827`	`if ( bugnote_exists( $t_bugnote_id ) ) {`
`832`	`828`	`bugnote_set_text( $t_bugnote_id, $t_note['text'] );`
`833`	`829`	`bugnote_set_view_state( $t_bugnote_id, $t_view_state_id == VS_PRIVATE );`
`834`		`- $t_eta_id = isset( $p_issue['eta'] ) ? mci_get_eta_id( $p_issue['eta'] ) : config_get('default_bug_eta');`
`835`	`830`	`bugnote_date_update( $t_bugnote_id );`
`836`	`831`	`if ( isset( $t_note['time_tracking'] ) )`
`837`	`832`	`bugnote_set_time_tracking( $t_bugnote_id, mci_get_time_tracking_from_note( $p_issue_id, $t_note ) );`
`@@ -846,8 +841,9 @@ function mc_issue_update( $p_username, $p_password, $p_issue_id, $p_issue ) {`
`846`	`841`	`}`
`847`	`842`	`}`
`848`	`843`	`}`
`849`		`-`
`850`		`- return $t_is_success;`
	`844`	`+`
	`845`	`+ # submit the issue`
	`846`	`+ return $t_is_success = $t_bug_data->update( /* update_extended / true, / bypass_email */ false);`
`851`	`847`	`}`
`852`	`848`
`853`	`849`	`/**`