fix for the ticket TRUNK-4198 #691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6754,6 +6754,17 @@ | |||
| <comment>Rename orders.discontinued_date to date_stopped</comment> | |||
| <renameColumn tableName="orders" oldColumnName="discontinued_date" newColumnName="date_stopped" columnDataType="datetime"/> | |||
| </changeSet> | |||
| <changeSet id="201403011303-TRUNK-4198" author="harsha"> | |||
There was a problem hiding this comment.
Can you split up these changesets into 2? One drops the foreign key constraint and the other drops the column, the reason for this is that in case teh key is dropped but dropping the column fails then the changeset can never be rerun after fixing the cause of the failure since the precondition would fail on subsequent reruns.
…moved includeRetired argument from ConceptService.getDrugByMapping - TRUNK-4214
Frequency - TRUNK-4188
Frequency - TRUNK-4188
…on, because that would break the uncaughtException page (cherry picked from commit cf9f6e1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.