Replace array flattening with manual handling in java_import #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could put the tests in test/jruby (they should be runnable directly, with only a few counterexamples) or in spec/regression. Former would probably be best since usually the latter is for Ruby behaviors (rather than JRuby behaviors) that aren't tested well in other suites. FWIW, this will get exercised heavily by other Java integration tests too. |
|
Two comments on the commit:
We'll only make this change on master, since it does have a potentially-visible behavior change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2324 by getting rid of flatten! as hinted by @headius. I thought about writing a test for the method, too, as I couldn't find any. Too bad, I couldn't find a way to run a single test in tests/jruby either. Is that the right place for such tests? Help appreciated.