opal · Jan 14, 2014 · Jan 14, 2014
Showing with 21 additions and 7 deletions.

+21 −7 opal/corelib/numeric.rb
diff --git a/opal/corelib/numeric.rb b/opal/corelib/numeric.rb
@@ -454,8 +454,8 @@ def zero?
     `self == 0`
   end
 
+  # Since bitwise operations are 32 bit, declare it to be so.
   def size
-    # Just a stub, JS is 32bit for bitwise ops though
     4
   end
 
@@ -464,15 +464,29 @@ def nan?
   end
 
   def finite?
-    `self == Infinity || self == -Infinity`
+    `self != Infinity && self != -Infinity`
   end
 
   def infinite?
-    if `self == Infinity`
-      `+1`
-    elsif `self == -Infinity`
-      `-1`
-    end
+    %x{
+      if (self == Infinity) {
+        return +1;
+      }
+      else if (self == -Infinity) {
+        return -1;
+      }
+      else {
+        return nil;
+      }
+    }
+  end
+
+  def positive?
+    `1 / self > 0`
+  end
+
+  def negative?
+    `1 / self < 0`
   end
 end