fixed bug in Mojolicious::Validator::Validation where every_param wou…

…ld sometimes return an array reference containing an undef value (closes #691)
mojolicious · Oct 17, 2014 · 2941f5e · 2941f5e
1 parent 7df037f
commit 2941f5e
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -1,5 +1,7 @@
 
 5.51  2014-10-17
+  - Fixed bug in Mojolicious::Validator::Validation where every_param would
+    sometimes return an array reference containing an undef value.
   - Fixed Mojo::ByteStream and Mojo::Collection to always return true in
     boolean context.
 

diff --git a/lib/Mojolicious/Validator/Validation.pm b/lib/Mojolicious/Validator/Validation.pm
@@ -92,7 +92,7 @@ sub required {
 }
 
 sub _param {
-  my $value = shift->output->{shift()};
+  return [] unless defined(my $value = shift->output->{shift()});
   return [ref $value eq 'ARRAY' ? @$value : $value];
 }
 

diff --git a/t/mojo/parameters.t b/t/mojo/parameters.t
@@ -67,6 +67,7 @@ is $params->to_string, 'bar=bar&foo=', 'right format';
 $params = Mojo::Parameters->new(foo => 0);
 is $params->param('foo'), 0, 'right value';
 is_deeply $params->every_param('foo'), [0], 'right value';
+is_deeply $params->every_param('bar'), [], 'no values';
 is $params->to_string, 'foo=0', 'right format';
 $params = Mojo::Parameters->new($params->to_string);
 is $params->param('foo'), 0, 'right value';

diff --git a/t/mojolicious/dispatch.t b/t/mojolicious/dispatch.t
@@ -72,6 +72,7 @@ is $c->param(foo => 'works')->param('foo'), 'works', 'right value';
 is $c->param(foo => 'too')->param('foo'),   'too',   'right value';
 is $c->param(foo => qw(just works))->param('foo'), 'works', 'right value';
 is_deeply $c->every_param('foo'), [qw(just works)], 'right values';
+is_deeply $c->every_param('bar'), [], 'no values';
 is $c->param(foo => undef)->param('foo'), undef, 'no value';
 is $c->param(foo => Mojo::Upload->new(name => 'bar'))->param('foo')->name,
   'bar', 'right value';

diff --git a/t/mojolicious/validation_lite_app.t b/t/mojolicious/validation_lite_app.t
@@ -36,6 +36,8 @@ my $t = Test::Mojo->new;
 # Required and optional values
 my $validation = $t->app->validation->input({foo => 'bar', baz => 'yada'});
 is_deeply [$validation->error], [], 'no names';
+is $validation->param('foo'), undef, 'no value';
+is_deeply $validation->every_param('foo'), [], 'no values';
 ok $validation->required('foo')->is_valid, 'valid';
 is_deeply $validation->output, {foo => 'bar'}, 'right result';
 is $validation->param('foo'), 'bar', 'right value';