Trunk 2472 #313
Merged
Trunk 2472 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @should get no one by voided attribute | ||
| * @should get one person by attribute | ||
| * @should get one person by random case attribute | ||
| * @should get one person by attribute and voided attribute |
There was a problem hiding this comment.
I think if an attribute is voided, then you shouldn't match against it, in OpenMRS voided is the same as deleted from the user's stand point, we just don't want to purge it from the DB for audit/history reasons
There was a problem hiding this comment.
The naming of the test description is wrong. The actual test asserts that a person can be found by using a non-voided and a voided attribute as search criteria. There are other tests which assert that searching for voided attributes only do not return the respective person.
I rephrase the @should to express the intention of the test in a better way.
dkayiwa
added a commit
that referenced
this pull request
Oct 4, 2013
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
* Added offline actions patient chart widget. * Prettier and translations. * Enhance offline sync API with members to support triggering edit flows for queued items. Added documentation to (most) exported sync API members. * Support invoking edit offline action flow within the offline actions table. * Don't export the internal SyncHandler. * Pin @jsenv/file-size-impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented searching people by searchable attributes.