Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: 367ff4f12ac5
Choose a base ref
...
head repository: cdk/cdk
compare: 4e35feb7be96
Choose a head ref
  • 5 commits
  • 5 files changed
  • 2 contributors

Commits on Oct 30, 2012

  1. Added an alternative aromaticity perception model, which is happy abo… 

    …ut double bonds pointing outwards from aromatic rings

Change-Id: I631ffb26431d5c80d1eb6495dbdff30e7113722e
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw
    egonw committed Oct 30, 2012
    Copy the full SHA
    b5bf695 View commit details
    Browse the repository at this point in the history

  2. Because the placement of double bonds is not deterministic, we cannot… 

    … be sure we always get them at the same location. Better is to just test that all carbons are perceived as C.sp2 and that they are aromatic.

Change-Id: Ifc5e41a8378de3e6b22f698c77a36fa67b88cbc8
Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw
    egonw committed Oct 30, 2012
    Copy the full SHA
    77a778f View commit details
    Browse the repository at this point in the history

  3. Testing that benzoquinone is perceived as aromatic using the alternat… 

    …ive detection method.

Change-Id: Ia64a05d62546f6bd055043e28da68e60c67b740e
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Oct 30, 2012
    Copy the full SHA
    702d8ba View commit details
    Browse the repository at this point in the history

  4. Removed cdk.create dates, as suggested by the reviewer 

    Change-Id: I3fbef0fde1991e4c9f737450bacfefd37027c907
    @egonw
    egonw committed Oct 30, 2012
    Copy the full SHA
    49b6541 View commit details
    Browse the repository at this point in the history

  5. Removed SVN tags, as suggested by the reviewer 

    Change-Id: I25728722640b54d2ca3d65f6d8758ce2adf10df6
    @egonw
    egonw committed Oct 30, 2012
    Copy the full SHA
    4e35feb View commit details
    Browse the repository at this point in the history