Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 7f09a13bbae6
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 5235d71f8950
Choose a head ref
  • 5 commits
  • 23 files changed
  • 1 contributor

Commits on Nov 11, 2013

  1. src: fix Environment::GetCurrent() usage

    Create a HandleScope before calling the Environment::GetCurrent() that
    takes a v8::Isolate* as an argument because it creates a handle with
    the call to v8::Isolate::CurrentContext().
    bnoordhuis committed Nov 11, 2013
    Copy the full SHA
    09724b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2013

  1. src: remove global HandleScope

    Make it more difficult to accidentally leak handles by removing the
    top-level HandleScope.  Now if there's no valid HandleScope now, V8
    will complain and, in debug builds, abort.
    bnoordhuis committed Nov 12, 2013
    Copy the full SHA
    fd819ef View commit details
    Browse the repository at this point in the history
  2. crypto: fix up implicit HandleScope abuse

    Don't depend on any HandleScope objects that may or may not have been
    created in src/stream_wrap.cc, create them explicitly.
    bnoordhuis committed Nov 12, 2013
    Copy the full SHA
    c0d62c2 View commit details
    Browse the repository at this point in the history
  3. src: fix Context::Scope usage

    env->context() may or may not create a new Local.  It currently does
    not but don't depend on that behavior, create a HandleScope first.
    bnoordhuis committed Nov 12, 2013
    Copy the full SHA
    27f115d View commit details
    Browse the repository at this point in the history
  4. src: use Context::Scope objects in cares_wrap.cc

    Enter the context explicitly, don't rely on the fact that there is a
    Context::Scope a few stack frames below because it may be gone someday
    bnoordhuis committed Nov 12, 2013
    Copy the full SHA
    5235d71 View commit details
    Browse the repository at this point in the history