Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
base: 5df3d933f145
Choose a base ref
...
head repository: mantisbt/mantisbt
compare: cba1af4b2365
Choose a head ref
  • 6 commits
  • 5 files changed
  • 1 contributor

Commits on Sep 19, 2012

  1. Cloning issues with attachments fails after upload folder changed

    With attachments stored on disk, if the project's upload directory
    changes and the files are moved to the new location, it is no longer
    possible to clone issues.
    
    The file_copy_attachments() function was modified to use the same logic
    as elsewhere in MantisBT, i.e. rely on file_normalize_attachment_path()
    to determine the attachment's path.
    
    Fixes #14718
    dregad committed Sep 19, 2012
    Copy the full SHA
    7f3b0e7 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2012

  1. Force validation of upload path if file_upload_method != DATABASE

    Prior to this, the upload path would not be checked if it was empty
    (ie. defaulting to $g_absolute_path_default_upload_folder),
    which could cause issues if that directory was missing or read-only.
    
    Checking this early allows catching any errors before users perform
    actual operations on file attachments.
    
    Fixes #14723
    dregad committed Sep 20, 2012
    Copy the full SHA
    7e27a16 View commit details
    Browse the repository at this point in the history
  2. Hide file upload path on project create page if storage is DB

    The logic implemented in 7aa07d8 for
    manage_proj_edit_page.php also applies to manage_proj_create_page.php.
    
    Fixes #14700
    dregad committed Sep 20, 2012
    Copy the full SHA
    45e7b99 View commit details
    Browse the repository at this point in the history
  3. Fix inconsistent behavior of upload path field hiding

    config_get() would return the file upload method for the current
    project, instead of the one for the project being edited.
    
    Use of $g_project_override for expected behavior.
    
    Fixes #14700
    dregad committed Sep 20, 2012
    Copy the full SHA
    8daa086 View commit details
    Browse the repository at this point in the history
  4. Make Manage Project Create and Edit pages consistent

    The following changes were made:
    
     - Display the fields in the same order
     - Make the fields identical length
     - replace uses of class="row-X" with helper_alternate_class() calls
     - Display the "required" star next to project name
     - Added comments
     - Use identical variable names
     - Align submit buttons the same way
    
    Fixes #14725
    dregad committed Sep 20, 2012
    Copy the full SHA
    0b5f7bc View commit details
    Browse the repository at this point in the history
  5. Fix config_get behavior with $g_project_override = ALL_PROJECTS

    Fixes #14724, affects #14700
    dregad committed Sep 20, 2012
    Copy the full SHA
    cba1af4 View commit details
    Browse the repository at this point in the history