Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed setters that were only used in tests #87

Merged
merged 1 commit into from Jun 27, 2013
Merged

Conversation

fasseg
Copy link
Contributor

@fasseg fasseg commented Jun 20, 2013

Added Testhelper method to set fields via reflection and changed the tests to use the new method
see https://www.pivotaltracker.com/story/show/52055161

@@ -18,7 +17,5 @@
@Path("/fcr:import")
public class FedoraRepositoryImport extends FedoraImport {

@InjectedSession
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can't remove this line. Yes, it looks silly, but I think @ajs6f said there's something nasty about the magic (proxying? reflection? whatever) that means we need this in every class we want an injected session in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it wont be enough if the super class has the annotation and the session? since the field is a duplicate...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess not...Ill try and catch Adam to ask him about the particulars...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you tried it, it shouldn't pass the tests, right? Because it doesn't inherit the injection behavior from FedoraImport or AbstractResource, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah all the tests do pass on this branch...

@ghost ghost assigned cbeer Jun 27, 2013
… to set fields via reflection and changed the tests to use the new method
@cbeer cbeer merged commit 8f432df into master Jun 27, 2013
@cbeer
Copy link
Contributor

cbeer commented Jun 27, 2013

I excised the InjectedSession change and rebased. We can figure out whether the InjectedSession notation is needed everywhere in a separate issue.

@cbeer cbeer deleted the reflection-test-helper branch June 27, 2013 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants