This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Fix child_process.kill oddities
* When the process is already dead, but the `exit` signal wasn't raised yet, the ESRCH error should be ignored. * When an invalid signal is specified, kill() should throw. * Like process.kill(), child_process.kill() now preserves a `0` signal which can be used to check the liveliness of the child process. * process.kill() and child_process.kill() will now return true if the signal was actually delivered, and false otherwise. * When an `exec`-ed process is automatically killed because a time or buffer limit is exceeded, and the kill() fails, this error should be reported through the `exec` callback. Fixes: #3409
- Loading branch information
1 parent
b53b8b8
commit 10f85fa
Showing
2 changed files
with
43 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -430,6 +430,8 @@ | |
if (r) { | ||
throw errnoException(errno, 'kill'); | ||
} | ||
|
||
return true; | ||
}; | ||
}; | ||
|
||
|