TRUNK-3586 Update unit testing environment to use mocks #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -249,7 +249,7 @@ public static UserContext getUserContext() { | |||
| * | |||
| * @return the current ServiceContext | |||
| */ | |||
| private static ServiceContext getServiceContext() { | |||
| static ServiceContext getServiceContext() { | |||
There was a problem hiding this comment.
does this expose Context to being insecurely impacted by modules directly, or is that not a big deal (or even a feature)?
There was a problem hiding this comment.
I don't think it's a big deal since the field has only package visibility. Actually, ServiceContext is a Spring bean and can be easily accessed even without this change.
There was a problem hiding this comment.
UserContext would be the one to worry about security on. Although as Rafal said, spring lets you get around almost anything.
rkorytkowski
added a commit
that referenced
this pull request
Jun 17, 2013
TRUNK-3586 Update unit testing environment to use mocks
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
…onattributetype) and better readability of data (openmrs#334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies mocking services accessed through Context.get...Service().