fixed a few small timing bugs in Mojo::Server::Daemon

mojolicious · Apr 10, 2013 · c5eb1a0 · c5eb1a0
1 parent 98a9919
commit c5eb1a0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -2,6 +2,7 @@
 3.95  2013-04-11
   - Improved documentation. (jberger, sri)
   - Improved tests.
+  - Fixed a few small timing bugs in Mojo::Server::Daemon.
 
 3.94  2013-04-08
   - Added is_hidden method to Mojolicious::Routes.

diff --git a/lib/Mojo/Server/Daemon.pm b/lib/Mojo/Server/Daemon.pm
@@ -210,7 +210,7 @@ sub _read {
   my ($self, $id, $chunk) = @_;
 
   # Make sure we have a transaction and parse chunk
-  my $c = $self->{connections}{$id};
+  return unless my $c = $self->{connections}{$id};
   my $tx = $c->{tx} ||= $self->_build_tx($id, $c);
   warn "-- Server <<< Client (@{[$tx->req->url->to_abs]})\n$chunk\n" if DEBUG;
   $tx->server_read($chunk);
@@ -234,7 +234,7 @@ sub _write {
   my ($self, $id) = @_;
 
   # Not writing
-  my $c = $self->{connections}{$id};
+  return unless my $c  = $self->{connections}{$id};
   return unless my $tx = $c->{tx};
   return unless $tx->is_writing;