This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
buffer: align fast buffers on 8 byte boundary
Prevents alignment issues when people create a typed array from a buffer. Unaligned loads or stores are less efficent and (on some architectures) unsafe.
- Loading branch information
285d8c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to check this on armv4t ! I still have that alignment issue with "über" test.
285d8c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With that patch applied on node 0.6.12,
test-buffer.js now pass on armv4t, while it's been failing reliably for quite some time.
285d8c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's good news. This commit is a provisional fix, there are more places that need alignment fix-ups. #3029 is the tracking issue.
285d8c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW all 0.6.12 tests pass on this armv5tel server
http://db.debian.org/machines.cgi?host=abel
but that's with the debian package (meaning using system v8, ev, cares).