Fix multicaller support in RequestQueue

sapier · kwolekr · commit dc407e219f8b · 2013-11-17T12:45:58.000-05:00
diff --git a/src/itemdef.cpp b/src/itemdef.cpp
@@ -638,12 +638,9 @@ class CItemDefManager: public IWritableItemDefManager
 		{
 			GetRequest<std::string, ClientCached*, u8, u8>
 					request = m_get_clientcached_queue.pop();
-			GetResult<std::string, ClientCached*, u8, u8>
-					result;
-			result.key = request.key;
-			result.callers = request.callers;
-			result.item = createClientCachedDirect(request.key, gamedef);
-			request.dest->push_back(result);
+
+			m_get_clientcached_queue.pushResult(request,
+					createClientCachedDirect(request.key, gamedef));
 		}
 #endif
 	}
diff --git a/src/shader.cpp b/src/shader.cpp
@@ -546,13 +546,7 @@ void ShaderSource::processQueue()
 				<<"name=\""<<request.key<<"\""
 				<<std::endl;*/
 
-		GetResult<std::string, u32, u8, u8>
-				result;
-		result.key = request.key;
-		result.callers = request.callers;
-		result.item = getShaderIdDirect(request.key);
-
-		request.dest->push_back(result);
+		m_get_shader_queue.pushResult(request,getShaderIdDirect(request.key));
 	}
 }
 
diff --git a/src/tile.cpp b/src/tile.cpp
@@ -786,13 +786,7 @@ void TextureSource::processQueue()
 				<<"name=\""<<request.key<<"\""
 				<<std::endl;*/
 
-		GetResult<std::string, u32, u8, u8>
-				result;
-		result.key = request.key;
-		result.callers = request.callers;
-		result.item = getTextureIdDirect(request.key);
-
-		request.dest->push_back(result);
+		m_get_texture_queue.pushResult(request,getTextureIdDirect(request.key));
 	}
 }
 
diff --git a/src/util/thread.h b/src/util/thread.h
@@ -106,53 +106,48 @@ class SimpleThread : public JThread
 	A single worker thread - multiple client threads queue framework.
 */
 
-template<typename Caller, typename Data>
-class CallerInfo
-{
-public:
-	Caller caller;
-	Data data;
-};
+
 
 template<typename Key, typename T, typename Caller, typename CallerData>
 class GetResult
 {
 public:
 	Key key;
 	T item;
-	std::list<CallerInfo<Caller, CallerData> > callers;
+	std::pair<Caller, CallerData> caller;
 };
 
 template<typename Key, typename T, typename Caller, typename CallerData>
 class ResultQueue: public MutexedQueue< GetResult<Key, T, Caller, CallerData> >
 {
 };
 
+template<typename Caller, typename Data, typename Key, typename T>
+class CallerInfo
+{
+public:
+	Caller caller;
+	Data data;
+	ResultQueue< Key, T, Caller, Data>* dest;
+};
+
 template<typename Key, typename T, typename Caller, typename CallerData>
 class GetRequest
 {
 public:
 	GetRequest()
 	{
-		dest = NULL;
-	}
-	GetRequest(ResultQueue<Key,T, Caller, CallerData> *a_dest)
-	{
-		dest = a_dest;
 	}
-	GetRequest(ResultQueue<Key,T, Caller, CallerData> *a_dest,
-			Key a_key)
+	GetRequest(Key a_key)
 	{
-		dest = a_dest;
 		key = a_key;
 	}
 	~GetRequest()
 	{
 	}
 	
 	Key key;
-	ResultQueue<Key, T, Caller, CallerData> *dest;
-	std::list<CallerInfo<Caller, CallerData> > callers;
+	std::list<CallerInfo<Caller, CallerData, Key, T> > callers;
 };
 
 template<typename Key, typename T, typename Caller, typename CallerData>
@@ -180,20 +175,21 @@ class RequestQueue
 
 			if(request.key == key)
 			{
-				for(typename std::list< CallerInfo<Caller, CallerData> >::iterator
+				for(typename std::list< CallerInfo<Caller, CallerData, Key, T> >::iterator
 						i = request.callers.begin();
 						i != request.callers.end(); ++i)
 				{
-					CallerInfo<Caller, CallerData> &ca = *i;
+					CallerInfo<Caller, CallerData, Key, T> &ca = *i;
 					if(ca.caller == caller)
 					{
 						ca.data = callerdata;
 						return;
 					}
 				}
-				CallerInfo<Caller, CallerData> ca;
+				CallerInfo<Caller, CallerData, Key, T> ca;
 				ca.caller = caller;
 				ca.data = callerdata;
+				ca.dest = dest;
 				request.callers.push_back(ca);
 				return;
 			}
@@ -205,11 +201,11 @@ class RequestQueue
 
 		GetRequest<Key, T, Caller, CallerData> request;
 		request.key = key;
-		CallerInfo<Caller, CallerData> ca;
+		CallerInfo<Caller, CallerData, Key, T> ca;
 		ca.caller = caller;
 		ca.data = callerdata;
+		ca.dest = dest;
 		request.callers.push_back(ca);
-		request.dest = dest;
 		
 		m_queue.getList().push_back(request);
 	}
@@ -219,6 +215,26 @@ class RequestQueue
 		return m_queue.pop_front(wait_if_empty);
 	}
 
+	void pushResult(GetRequest<Key, T, Caller, CallerData> req,
+					T res) {
+
+		for(typename std::list< CallerInfo<Caller, CallerData, Key, T> >::iterator
+				i = req.callers.begin();
+				i != req.callers.end(); ++i)
+		{
+			CallerInfo<Caller, CallerData, Key, T> &ca = *i;
+
+			GetResult<Key,T,Caller,CallerData> result;
+
+			result.key = req.key;
+			result.item = res;
+			result.caller.first = ca.caller;
+			result.caller.second = ca.data;
+
+			ca.dest->push_back(result);
+		}
+	}
+
 private:
 	MutexedQueue< GetRequest<Key, T, Caller, CallerData> > m_queue;
 };

Original file line number	Diff line number	Diff line change
`@@ -638,12 +638,9 @@ class CItemDefManager: public IWritableItemDefManager`
`638`	`638`	`{`
`639`	`639`	`GetRequest<std::string, ClientCached*, u8, u8>`
`640`	`640`	`request = m_get_clientcached_queue.pop();`
`641`		`- GetResult<std::string, ClientCached*, u8, u8>`
`642`		`- result;`
`643`		`- result.key = request.key;`
`644`		`- result.callers = request.callers;`
`645`		`- result.item = createClientCachedDirect(request.key, gamedef);`
`646`		`- request.dest->push_back(result);`
	`641`	`+`
	`642`	`+ m_get_clientcached_queue.pushResult(request,`
	`643`	`+ createClientCachedDirect(request.key, gamedef));`
`647`	`644`	`}`
`648`	`645`	`#endif`
`649`	`646`	`}`
Original file line number	Diff line number	Diff line change
`@@ -546,13 +546,7 @@ void ShaderSource::processQueue()`
`546`	`546`	`<<"name=\""<<request.key<<"\""`
`547`	`547`	`<<std::endl;*/`
`548`	`548`
`549`		`- GetResult<std::string, u32, u8, u8>`
`550`		`- result;`
`551`		`- result.key = request.key;`
`552`		`- result.callers = request.callers;`
`553`		`- result.item = getShaderIdDirect(request.key);`
`554`		`-`
`555`		`- request.dest->push_back(result);`
	`549`	`+ m_get_shader_queue.pushResult(request,getShaderIdDirect(request.key));`
`556`	`550`	`}`
`557`	`551`	`}`
`558`	`552`
Original file line number	Diff line number	Diff line change
`@@ -786,13 +786,7 @@ void TextureSource::processQueue()`
`786`	`786`	`<<"name=\""<<request.key<<"\""`
`787`	`787`	`<<std::endl;*/`
`788`	`788`
`789`		`- GetResult<std::string, u32, u8, u8>`
`790`		`- result;`
`791`		`- result.key = request.key;`
`792`		`- result.callers = request.callers;`
`793`		`- result.item = getTextureIdDirect(request.key);`
`794`		`-`
`795`		`- request.dest->push_back(result);`
	`789`	`+ m_get_texture_queue.pushResult(request,getTextureIdDirect(request.key));`
`796`	`790`	`}`
`797`	`791`	`}`
`798`	`792`