I understand the test, but I also know that HTTP::Tiny returns a hashref while LWP::UserAgent returns an object. That makes the test superfluous. Do you really want to add it anyway?

I don't know how that piece of docs was introduced, it's clearly wrong. Shouldn't we just fix that than add the test?

The docs here already pretty clearly state the need for HTTP::Tiny compat: https://metacpan.org/pod/MetaCPAN::Client::Request#ua

That said, I do think it's useful to support LWP::UserAgent. It has a lot more power than HTTP::Tiny and sometimes that is needed. I'm assuming a shim layer wrapping an LWP::UserAgent object could do most of the API translation work, and obviously could be outside of MetaCPAN::Client itself.

Yeah, but see the SYNOPSIS:

# simple usage
my $mcpan  = MetaCPAN::Client->new();
my $author = $mcpan->author('XSAWYERX');
my $dist   = $mcpan->distribuion('MetaCPAN-Client');

# advanced usage with cache (contributed by Kent Fredric)
use CHI;
use WWW::Mechanize::Cached;
use HTTP::Tiny::Mech;
use MetaCPAN::Client;

my $mcpan = MetaCPAN::Client->new(
  ua => HTTP::Tiny::Mech->new(
    mechua => WWW::Mechanize::Cached->new(
      cache => CHI->new(
        driver   => 'File',
        root_dir => '/tmp/metacpan-cache',
      ),
    ),
  ),
);

That contradicts the HTTP::Tiny compat and actually predates it, since the SYNOPSIS is from MetaCPAN::API. I was thinking of writing a HTTP::Any that would let you provide various UserAgents and would then "do the right thing". The problem here is that the very easy caching method which was previously supported is now broken.

@xsawyerx I'm not fussed about whether the test gets added. I just wanted to demonstrate the problem in a way that makes it easy to address.

@oalders Wait, what in the SYNOPSIS is giving LWP to MetaCPAN::Client? The ua is set to an HTTP::Tiny::Mech object which seems like it is supposed to do the ua wrapping.

@tsibley you're right. I stopped reading the SYNOPSIS at ua => ... so I didn't see HTTP::Tiny::Mech. So, I guess that solves it for me. :)

That makes more sense.

@tsibley++
@oalders++