Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 49e3fcd05852
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 9a6c0853bc16
Choose a head ref
  • 3 commits
  • 6 files changed
  • 1 contributor

Commits on May 30, 2013

  1. process: relocate needSpinner calls 

    It's only necessary to request the spinner once tickDone has been
called, and not on every nextTick.
    @trevnorris
    trevnorris committed May 30, 2013
    Copy the full SHA
    5b636fe View commit details
    Browse the repository at this point in the history

  2. process: remove maxTickDepth from _tickCallback 

    Removes the check for maxTickDepth for non-domain callbacks. So a user
can starve I/O by setting a recursive nextTick.

The domain case is more complex and will be addressed in another commit.
    @trevnorris
    trevnorris committed May 30, 2013
    Copy the full SHA
    0761c90 View commit details
    Browse the repository at this point in the history

  3. process: remove max tick check for domains 

    maxTickDepth checks have been removed for domains and replaced with a
flag that checks if the last callback threw. If it did then execution of
the remaining tickQueue is deferred to the spinner.

This is to prevent domains from entering a continuous loop when an error
callback also throws an error.
    @trevnorris
    trevnorris committed May 30, 2013
    Copy the full SHA
    9a6c085 View commit details
    Browse the repository at this point in the history