New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Members controller refactoring #460
Conversation
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
I tried to find in js as well, but at no avail I'm afraid. It does seem as a leftover, whose use has been replaced at some point in time with action_findmembers (formerly JSMembers())... This action_requestmembers() method comes from a SMF 2.0/2.1 Subs- function, which also doesn't seem actually called. Unless we do things like $scripturl + '?action=re' + 'questm' + 'embers' (lol), I'd be tempted to say it isn't used... and test that! ;) |
Searching around it was used in 1.1 (and maybe 1.0) to fill the PM names.
But then in 2.0 SMF started to use the autosuggest and probably this has been kept for some kind of backward compatibility. 👍 for dropping it! :D |
Or simply forgotten. |
Of course that's another possibility. 👼 |
Looking good to me, dropping some more code ftw :) |
No description provided.