readline: handle null completer graciously

Fixes #1698.
nodejs · Sep 14, 2011 · 92d4ed3 · 92d4ed3
1 parent 244675c
commit 92d4ed3
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/lib/readline.js b/lib/readline.js
@@ -45,6 +45,12 @@ function Interface(input, output, completer) {
   }
   EventEmitter.call(this);
 
+  completer = completer || function() { return []; };
+
+  if (typeof completer !== 'function') {
+    throw new TypeError("Argument 'completer' must be a function");
+  }
+
   var self = this;
 
   this.output = output;
@@ -605,9 +611,7 @@ Interface.prototype._ttyWrite = function(s, key) {
         break;
 
       case 'tab': // tab completion
-        if (this.completer) {
-          this._tabComplete();
-        }
+        this._tabComplete();
         break;
 
       case 'left':