Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display maxPages in the footerTemplate #890

Closed
wants to merge 2 commits into from
Closed

Display maxPages in the footerTemplate #890

wants to merge 2 commits into from

Conversation

jdecool
Copy link

@jdecool jdecool commented Dec 16, 2013

No description provided.

@c0bra
Copy link
Contributor

c0bra commented Dec 16, 2013

What if the grid creator does not know the maximum number of pages, e.g. in the case you're using an API that doesn't send back a maximum number of results / pages?

Can't this just be something anyone can configure with a custom footer template?

@jdecool
Copy link
Author

jdecool commented Dec 16, 2013

It's a basic feature and I think it should be in the component by default.

I just push a new commit to display the counter only if there is at least one page.

@jdecool
Copy link
Author

jdecool commented Jan 6, 2014

Some news about this PR ?

@c0bra c0bra added this to the 2.0.8 milestone Mar 21, 2014
@c0bra
Copy link
Contributor

c0bra commented Apr 22, 2014

Thanks! Merged with 60165a9

@c0bra c0bra closed this Apr 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants