Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: bd8a5755dced
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 5e06ce4fb949
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 5, 2014

  1. test: test sending a handle twice 

    Added test-cluster-send-handle-twice.js testing to send a handle
twice to the parent process.
    @tjfontaine
    Benoit Vallée authored and tjfontaine committed Mar 5, 2014
    Copy the full SHA
    a9d24fa View commit details
    Browse the repository at this point in the history

  2. child_process: fix sending handle twice 

    When sending a socket to a child process via IPC pipe,
`child_process.js` picks a raw UV handle from `_handle` property, sends
it, and assigns `null` to the property. Sending the same socket twice
was resulting in a runtime error, since we weren't handling the empty
`_handle` case.

In case of `null` `_handle` we should send just a plain text message
as passed it was passed to `.send()` and ignore the handle, letting
users handle such cases themselves instead of throwing the error at
runtime.

fix #5469
    @indutny @tjfontaine
    indutny authored and tjfontaine committed Mar 5, 2014
    Copy the full SHA
    5e06ce4 View commit details
    Browse the repository at this point in the history