Extract JCR-agnostic resource interfaces out of FedoraResource/Datastream #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
resource-interfaces
branch
from
3f677f8
to
8f746de
Compare
| * @since 9/16/14 | ||
| */ | ||
| public interface BinarySource<T, V> extends Resource<T> { | ||
| /** |
There was a problem hiding this comment.
What's V here? It's something that isn't an InputStream... is it typically going to be a JCR Binary?
There was a problem hiding this comment.
Yep. Likely overkill to avoid JCR in the interface.
There was a problem hiding this comment.
It's fine with me-- just maybe we should explain the diff between getContent() and getBinaryContent.
There was a problem hiding this comment.
I hope one or both will be going away.
There was a problem hiding this comment.
I'm also running out of things to call these classes/interfaces that don't conflict with other things we're using, so naming suggestions are welcome.
There was a problem hiding this comment.
Let's see. What's generic enough to be useful?
ThingPieceSliceOfTheWorldBasketOfOntologicalClaimsWhatchamacallitThingamabob- ...
Useful?
cbeer
force-pushed
the
getTriples
branch
3 times, most recently
from
8038c06
to
b599d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.