Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Kernel#itself method for now #3192

Closed
wants to merge 1 commit into from
Closed

Remove the Kernel#itself method for now #3192

wants to merge 1 commit into from

Conversation

robin850
Copy link
Contributor

@robin850 robin850 commented Nov 8, 2014

Hello,

Since this method is a 2.2+ feature and current master is still bumped to Ruby 2.1.0, let's remove it for now.

Have a nice day.

Since this method is a 2.2+ feature and current master is still
bumped to Ruby 2.1.0, let's remove it for now.
@yorickpeterse
Copy link
Contributor

I did some extra thinking about this and I'm having doubts if this is the way to go. For one the spec itself doesn't have to be removed as it already contains a version guard. Second, I don't think removing this method actually helps. Once we officially implement Ruby 2.2 we'd have to then re-add it (or revert this PR), which doesn't really make things easier. Besides, keeping the method shouldn't hinder anybody.

In other words, I strongly feel we should just keep this method. In the future Ruby 2.2 changes should be submitted to the 2.2 branch instead.

@jc00ke
Copy link
Member

jc00ke commented Nov 8, 2014

I agree @yorickpeterse, we should be more diligent in the future about new additions and the branches they go on, but for now I don't think this will hurt.

@jc00ke jc00ke closed this Nov 8, 2014
@brixen
Copy link
Member

brixen commented Nov 8, 2014

@robin850 can you explain the reason you are asking for it to be removed?

Removing it now and re-adding it for Ruby 2.2 compatibility is not a problem. If the method being there is causing a problem, we should remove it.

@brixen brixen reopened this Nov 8, 2014
@robin850
Copy link
Contributor Author

robin850 commented Nov 9, 2014

To be honest with you nope, this is not causing any problem. This is just not logical in my opinion to have forward features. We discussed that it was a bad practice on IRC but still, people may make the assumption that if Kernel#itself is available then the current Ruby is 2.2+ so things like Float#next_float are available as well.

Anyway, there's no big deal there. This pull request was just raised because I thought it was unintentional that Rubinius already has this method. You can close it if you guys prefer no to "re-revert" this patch later ! :-)

@brixen
Copy link
Member

brixen commented Nov 9, 2014

@robin850 ah, thank you for the explanation. I misunderstood in the IRC conversation that it was causing a problem.

In general, we won't pre-release MRI features. This one got in because we didn't have a clear procedure about where the upcoming MRI features should go. They should go on a 2.2 branch for now.

Since it's not causing a problem, I agree with @yorickpeterse and @jc00ke.

@brixen brixen closed this Nov 9, 2014
@robin850 robin850 deleted the itself-removal branch November 9, 2014 17:18
@robin850
Copy link
Contributor Author

robin850 commented Nov 9, 2014

Cool, no problem ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants