Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: CocoaPods/CocoaPods
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.6.0
Choose a base ref
...
head repository: CocoaPods/CocoaPods
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.6.1
Choose a head ref
  • 11 commits
  • 9 files changed
  • 2 contributors

Commits on Jul 1, 2012

  1. Another gem:release fix.

    alloy committed Jul 1, 2012

    Unverified

    No user is associated with the committer email.
    Copy the full SHA
    94155a8 View commit details

Commits on Jul 2, 2012

  1. [Specification] Use accessor to check if a spec requires ARC.

    Currently the setting is a top level attribute accessor,
    in the future it should be supported for subspecs.
    
    Closes #364.
    fabiopelosin committed Jul 2, 2012

    Unverified

    No user is associated with the committer email.
    Copy the full SHA
    2c617aa View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    2368500 View commit details
  3. Copy the full SHA
    eede812 View commit details
  4. Copy the full SHA
    28da91a View commit details
  5. Copy the full SHA
    ee2dc5f View commit details
  6. Copy the full SHA
    943e14c View commit details
  7. Update bundle for Xcodeproj.

    alloy committed Jul 2, 2012
    Copy the full SHA
    a4cb69c View commit details
  8. Clean Rakefile a bit.

    alloy committed Jul 2, 2012
    Copy the full SHA
    476ed93 View commit details
  9. Copy the full SHA
    55e8d38 View commit details
  10. Release 0.6.1

    alloy committed Jul 2, 2012
    Copy the full SHA
    ebd1176 View commit details
Showing with 31 additions and 25 deletions.
  1. +1 −1 CHANGELOG.md
  2. +15 −6 Gemfile.lock
  3. +3 −3 Rakefile
  4. +1 −1 cocoapods.gemspec
  5. +1 −1 lib/cocoapods.rb
  6. +1 −0 lib/cocoapods/command/push.rb
  7. +2 −3 lib/cocoapods/command/setup.rb
  8. +3 −8 lib/cocoapods/specification.rb
  9. +4 −2 spec/unit/specification_spec.rb
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -352,5 +352,5 @@ allowing you to automate Xcode related tasks.
[3]: https://github.com/CocoaPods/CocoaPods/blob/master/lib/cocoapods/podfile.rb#L185
[4]: https://github.com/CocoaPods/Xcodeproj
[5]: https://github.com/tomaz/appledoc
[6]: https://github.com/CocoaPods/CocoaPods/compare/0.5.1...HEAD
[6]: https://github.com/CocoaPods/CocoaPods/compare/0.5.1...0.6.0
[7]: https://github.com/CocoaPods/CocoaPods/compare/0.3.10...0.5.0
21 changes: 15 additions & 6 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
GIT
remote: git://github.com/CocoaPods/Xcodeproj.git
revision: 4c49ed5c0fb4f021b73afd69515ac4aec1765f81
revision: 4042ea00c560f806807bc0a8ad2a8761102d40d8
branch: develop
specs:
xcodeproj (0.2.0)
xcodeproj (0.2.1)

PATH
remote: .
specs:
cocoapods (0.6.0)
cocoapods (0.6.1)
colored (~> 1.2)
escape (~> 0.0.4)
faraday (~> 0.8.1)
json (~> 1.7.3)
octokit (~> 1.7.0)
open4 (~> 1.3.0)
rake (~> 0.9.0)
xcodeproj (~> 0.2.0)
xcodeproj (~> 0.2.1)

GEM
remote: http://rubygems.org/
@@ -32,11 +32,16 @@ GEM
multipart-post (~> 1.1)
faraday_middleware (0.8.8)
faraday (>= 0.7.4, < 0.9)
ffi (1.0.11)
github-markup (0.7.2)
hashie (1.2.0)
json (1.7.3)
kicker (2.5.0)
rb-fsevent
kicker (2.6.0)
listen
listen (0.4.7)
rb-fchange (~> 0.0.5)
rb-fsevent (~> 0.9.1)
rb-inotify (~> 0.8.8)
metaclass (0.0.1)
method_source (0.7.1)
mocha (0.11.4)
@@ -57,7 +62,11 @@ GEM
method_source (~> 0.7.1)
slop (>= 2.4.4, < 3)
rake (0.9.2.2)
rb-fchange (0.0.5)
ffi
rb-fsevent (0.9.1)
rb-inotify (0.8.8)
ffi (>= 0.5.0)
redcarpet (2.1.1)
slop (2.4.4)
vcr (2.2.2)
6 changes: 3 additions & 3 deletions Rakefile
Original file line number Diff line number Diff line change
@@ -48,7 +48,7 @@ end

namespace :gem do
def gem_version
require File.join(File.dirname(__FILE__), *%w[lib cocoapods])
require File.expand_path('../lib/cocoapods', __FILE__)
Pod::VERSION
end

@@ -67,7 +67,6 @@ namespace :gem do
end

def silent_sh(command)
#output = `/bin/sh -c '#{command}' 2>&1`
output = `#{command} 2>&1`
unless $?.success?
puts output
@@ -148,7 +147,7 @@ namespace :gem do

# Update the last version in CocoaPods-version.yml
puts "* Updating last known version in Specs repo"
specs_branch = '0.6'
specs_branch = 'master'
Dir.chdir('../Specs') do
puts Dir.pwd
sh "git checkout #{specs_branch}"
@@ -159,6 +158,7 @@ namespace :gem do
$stderr.puts "[!] Unable to find #{yaml_file}!"
exit 1
end
require 'yaml'
cocoapods_version = YAML.load_file(yaml_file)
cocoapods_version['last'] = gem_version
File.open(yaml_file, "w") do |f|
2 changes: 1 addition & 1 deletion cocoapods.gemspec
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ Gem::Specification.new do |s|
s.add_runtime_dependency 'json', '~> 1.7.3'
s.add_runtime_dependency 'open4', '~> 1.3.0'
s.add_runtime_dependency 'rake', '~> 0.9.0'
s.add_runtime_dependency 'xcodeproj', '~> 0.2.0'
s.add_runtime_dependency 'xcodeproj', '~> 0.2.1'

s.add_development_dependency 'bacon', '~> 1.1'

2 changes: 1 addition & 1 deletion lib/cocoapods.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module Pod
VERSION = '0.6.0'
VERSION = '0.6.1'

class PlainInformative < StandardError
end
1 change: 1 addition & 0 deletions lib/cocoapods/command/push.rb
Original file line number Diff line number Diff line change
@@ -71,6 +71,7 @@ def validate_podspec_files
lint_argv = ["lint"]
lint_argv << "--only-errors" if @allow_warnings
lint_argv << "--silent" if config.silent
lint_argv += podspec_files.map(&:to_s)
all_valid = Spec.new(ARGV.new(lint_argv)).run
end

5 changes: 2 additions & 3 deletions lib/cocoapods/command/setup.rb
Original file line number Diff line number Diff line change
@@ -71,17 +71,16 @@ def set_master_repo_url
end

def add_master_repo
@command ||= Repo.new(ARGV.new(['add', 'master', url, '0.6'])).run
@command ||= Repo.new(ARGV.new(['add', 'master', url, 'master'])).run
end

def update_master_repo
Repo.new(ARGV.new(['update', 'master'])).run
end

#TODO: remove after rc
def set_master_repo_branch
Dir.chdir(dir) do
git("checkout 0.6")
git("checkout master")
end
end

11 changes: 3 additions & 8 deletions lib/cocoapods/specification.rb
Original file line number Diff line number Diff line change
@@ -264,16 +264,11 @@ def raw_xconfig

def compiler_flags
if @parent
chained = @compiler_flags[active_platform].clone
# TODO hack to get the parent's compiler flags without it being
# converted to a String by Specification#compiler_flags.
chained.unshift @parent.instance_variable_get(:@compiler_flags)[active_platform]
flags = [@parent.compiler_flags]
else
chained = @compiler_flags[active_platform].clone
chained.unshift '-fobjc-arc' if @requires_arc
chained.unshift ''
flags = [requires_arc ? ' -fobjc-arc' : '']
end
chained.join(' ')
(flags + @compiler_flags[active_platform].clone).join(' ')
end

platform_attr_writer :compiler_flags, lambda {|value, current| current << value }
6 changes: 4 additions & 2 deletions spec/unit/specification_spec.rb
Original file line number Diff line number Diff line change
@@ -321,7 +321,7 @@

it "automatically forwards top level attributes to the top level parent" do
@spec.activate_platform(:ios)
[:version, :license, :authors, :requires_arc].each do |attr|
[:version, :license, :authors, :requires_arc, :compiler_flags].each do |attr|
@spec.subspecs.first.send(attr).should == @spec.send(attr)
@spec.subspecs.first.subspecs.first.send(attr).should == @spec.send(attr)
end
@@ -332,8 +332,10 @@
@spec.source_files.map { |f| f.to_s }.should == %w[ spec.m ]
@subspec.source_files.map { |f| f.to_s }.should == %w[ spec.m subspec_ios.m ]
@subsubspec.source_files.map { |f| f.to_s }.should == %w[ spec.m subspec_ios.m subsubspec.m ]

@subsubspec.resources.should == %w[ resource ]

@subsubspec.compiler_flags = '-Wdeprecated-implementations'
@subsubspec.compiler_flags.should == ' -fobjc-arc -Wdeprecated-implementations'
end

it "returns empty arrays for chained attributes with no value in the chain" do