Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html2 md #401

Merged
merged 18 commits into from May 14, 2013
Merged

Html2 md #401

merged 18 commits into from May 14, 2013

Conversation

norv
Copy link
Contributor

@norv norv commented May 14, 2013

Add html->markdown library.

Spuds and others added 18 commits May 14, 2013 20:08
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
…nested

Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
…, etc

Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
…es not improperly get converted

! links should have htmlcharacters decoded for text output

Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
! check for null object before trying to get the attributes
! add rendering of center tag as a block element

Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Norv <a.w.norv@gmail.com>
norv added a commit that referenced this pull request May 14, 2013
@norv norv merged commit 5183c1d into elkarte:master May 14, 2013
@norv
Copy link
Contributor Author

norv commented May 14, 2013

We could remove markdownify I guess, I left it alone for testing needs eventually, not sure

@joshuaadickerson
Copy link
Contributor

How does this get used?

@norv
Copy link
Contributor Author

norv commented May 14, 2013

@Spuds
Copy link
Contributor

Spuds commented May 14, 2013

We could remove markdownify I guess, I left it alone for testing needs eventually, not sure

Yes its either this or that, or another is someone wants to take a crack at it 😃 ... markdownify has not been worked on in some time, does more than we really need, and is lgpl which had me wondering about changing it and implications etc ...

So thats why I initially did this class as and experiment to replace, plus I did not think it would be to complicated ... well the basic things are not but things do get a bit muddy for some tags at least doing it as a dom traversal that I went with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants