TRUNK-2224 Show appropriate notification message when void reason is empty when voiding a patient #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empty when voiding a patient
| @@ -49,8 +49,8 @@ | |||
| * render the patient dashboard model and direct to the view | |||
| */ | |||
| @RequestMapping("/patientDashboard.form") | |||
| protected String renderDashboard(@RequestParam(required = true, value = "patientId") Integer patientId, ModelMap map, HttpServletRequest request) | |||
| throws Exception { | |||
| protected String renderDashboard(@RequestParam(required = true, value = "patientId") Integer patientId, ModelMap map, | |||
There was a problem hiding this comment.
This automatically got changed after running "mvn clean install". I hope it's fine. :)
|
@aka001 i think some of the recent user interface changes could have confused you a bit. But i have put the explanation in the earlier comments. Deleting from the user interface is internally voiding in the API. Address this and create a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeating the comment put in the previous pr)
@dkayiwa
yaa true that but the point I am trying to make is.
When one clicks on "Delete" button the block containing the message:
action.equals(msa.getMessage("Patient.delete")) gets triggered and we can find out whether the "delete reason" provided by the user is empty or not,
by using the command, StringUtils.isNotBlank(patient.getVoidReason())
I have thoroughly tested this.
P.S. Talking about the version openmrs 1.11