Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 4bc024ddecf4
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: c16963b977b3
Choose a head ref
  • 1 commit
  • 9 files changed
  • 1 contributor

Commits on Jun 26, 2013

  1. src: break on uncaught exception

    Most TryCatch blocks have SetVerbose flag on, this tells V8 to report
    uncaught exceptions to debugger.
    
    FatalException handler is called from V8 Message listener instead from
    the place where TryCatch was used. Otherwise uncaught exceptions are
    logged twice.
    
    See comment in `deps/v8/include/v8.h` for explanation of SetVerbose
    flag:
    
    >  By default, exceptions that are caught by an external exception
    >  handler are not reported.  Call SetVerbose with true on an
    >  external exception handler to have exceptions caught by the
    >  handler reported as if they were not caught.
    
    The flag is used by `Isolate::ShouldReportException()`, which is called
    by `Isolate::DoThrow()` to decide whether an exception is considered
    uncaught.
    bajtos authored and bnoordhuis committed Jun 26, 2013
    Copy the full SHA
    c16963b View commit details
    Browse the repository at this point in the history