Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pmdfixes/qsaranddatadebugnaming #78

Closed
wants to merge 7 commits into from

Conversation

johnmay
Copy link
Member

@johnmay johnmay commented Oct 2, 2014

Resolves PMD variable naming violations in qsar* and datadebug modules.

@egonw
Copy link
Member

egonw commented Nov 10, 2014

All but the last approved. The last causes compile errors, like in this line:

logger.debug("Setting flag: ", flagType + "=" + super.getFlag(flag_type));

The last part still has a flag_type...

@johnmay
Copy link
Member Author

johnmay commented Nov 10, 2014

My bad, thanks for catching that.

@johnmay johnmay closed this Nov 10, 2014
@johnmay johnmay deleted the pmdfixes/qsaranddatadebugnaming branch December 28, 2014 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants