Fix #15451: Incorrect invocations of SoapObjectsFactory::newSoapFault

cybd · rombert · commit 37631b83ba6b · 2013-01-31T21:15:25.000+02:00
Signed-off-by: Robert Munteanu &lt;robert@lmn.ro&gt;
diff --git a/api/soap/mc_project_api.php b/api/soap/mc_project_api.php
@@ -183,7 +183,7 @@ function mc_project_rename_category_by_name( $p_username, $p_password, $p_projec
         $t_user_id = mci_check_login( $p_username, $p_password );
 
         if ( null === $p_assigned_to ) {
-                return SoapObjectsFactory::newSoapFault( 'Client', '', 'p_assigned_to needed' );
+                return SoapObjectsFactory::newSoapFault( 'Client', 'p_assigned_to needed' );
         }
 
         if( $t_user_id === false ) {
@@ -221,7 +221,7 @@ function mc_project_get_versions( $p_username, $p_password, $p_project_id ) {
 	}
 
 	if( !project_exists( $p_project_id ) ) {
-		return SoapObjectsFactory::newSoapFault( 'Client', '', "Project '$p_project_id' does not exist." );
+		return SoapObjectsFactory::newSoapFault( 'Client', "Project '$p_project_id' does not exist." );
 	}
 
 	if( !mci_has_readonly_access( $t_user_id, $p_project_id ) ) {
@@ -554,7 +554,7 @@ function mc_project_get_attachments( $p_username, $p_password, $p_project_id ) {
 	}
 
 	if( !project_exists( $p_project_id ) ) {
-		return SoapObjectsFactory::newSoapFault( 'Client', '', "Project '$p_project_id' does not exist." );
+		return SoapObjectsFactory::newSoapFault( 'Client', "Project '$p_project_id' does not exist." );
 	}
 
 	if( !mci_has_readonly_access( $t_user_id, $p_project_id ) ) {
@@ -700,7 +700,7 @@ function mc_project_add( $p_username, $p_password, $p_project ) {
 	
 
 	if ( !isset( $p_project['name'] ) ) {
-		return SoapObjectsFactory::newSoapFault( 'Client', '', 'Required field "name" is missing' );
+		return SoapObjectsFactory::newSoapFault( 'Client', 'Required field "name" is missing' );
 	} else {
 		$t_name = $p_project['name'];
 	}
diff --git a/api/soap/mc_project_attachment_api.php b/api/soap/mc_project_attachment_api.php
@@ -56,7 +56,7 @@ function mc_project_attachment_add( $p_username, $p_password, $p_project_id, $p_
 		return mci_soap_fault_access_denied( $t_user_id );
 	}
 	if( is_blank( $p_title ) ) {
-		return SoapObjectsFactory::newSoapFault( 'Client', '', 'Title must not be empty.' );
+		return SoapObjectsFactory::newSoapFault( 'Client', 'Title must not be empty.' );
 	}
 	return mci_file_add( $p_project_id, $p_name, $p_content, $p_file_type, 'project', $p_title, $p_description, $t_user_id );
 }

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ function mc_project_rename_category_by_name( $p_username, $p_password, $p_projec`
`183`	`183`	`$t_user_id = mci_check_login( $p_username, $p_password );`
`184`	`184`
`185`	`185`	`if ( null === $p_assigned_to ) {`
`186`		`- return SoapObjectsFactory::newSoapFault( 'Client', '', 'p_assigned_to needed' );`
	`186`	`+ return SoapObjectsFactory::newSoapFault( 'Client', 'p_assigned_to needed' );`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`if( $t_user_id === false ) {`
`@@ -221,7 +221,7 @@ function mc_project_get_versions( $p_username, $p_password, $p_project_id ) {`
`221`	`221`	`}`
`222`	`222`
`223`	`223`	`if( !project_exists( $p_project_id ) ) {`
`224`		`- return SoapObjectsFactory::newSoapFault( 'Client', '', "Project '$p_project_id' does not exist." );`
	`224`	`+ return SoapObjectsFactory::newSoapFault( 'Client', "Project '$p_project_id' does not exist." );`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`if( !mci_has_readonly_access( $t_user_id, $p_project_id ) ) {`
`@@ -554,7 +554,7 @@ function mc_project_get_attachments( $p_username, $p_password, $p_project_id ) {`
`554`	`554`	`}`
`555`	`555`
`556`	`556`	`if( !project_exists( $p_project_id ) ) {`
`557`		`- return SoapObjectsFactory::newSoapFault( 'Client', '', "Project '$p_project_id' does not exist." );`
	`557`	`+ return SoapObjectsFactory::newSoapFault( 'Client', "Project '$p_project_id' does not exist." );`
`558`	`558`	`}`
`559`	`559`
`560`	`560`	`if( !mci_has_readonly_access( $t_user_id, $p_project_id ) ) {`
`@@ -700,7 +700,7 @@ function mc_project_add( $p_username, $p_password, $p_project ) {`
`700`	`700`
`701`	`701`
`702`	`702`	`if ( !isset( $p_project['name'] ) ) {`
`703`		`- return SoapObjectsFactory::newSoapFault( 'Client', '', 'Required field "name" is missing' );`
	`703`	`+ return SoapObjectsFactory::newSoapFault( 'Client', 'Required field "name" is missing' );`
`704`	`704`	`} else {`
`705`	`705`	`$t_name = $p_project['name'];`
`706`	`706`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ function mc_project_attachment_add( $p_username, $p_password, $p_project_id, $p_`
`56`	`56`	`return mci_soap_fault_access_denied( $t_user_id );`
`57`	`57`	`}`
`58`	`58`	`if( is_blank( $p_title ) ) {`
`59`		`- return SoapObjectsFactory::newSoapFault( 'Client', '', 'Title must not be empty.' );`
	`59`	`+ return SoapObjectsFactory::newSoapFault( 'Client', 'Title must not be empty.' );`
`60`	`60`	`}`
`61`	`61`	`return mci_file_add( $p_project_id, $p_name, $p_content, $p_file_type, 'project', $p_title, $p_description, $t_user_id );`
`62`	`62`	`}`