Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7ee7b94b4857
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b083103ba6ac
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Dec 2, 2014

  1. [Truffle] De-duplicate guard and name it appropriately.

    @eregon
    eregon committed Dec 2, 2014
    Copy the full SHA
    c88261f View commit details

  2. [Truffle] No need for a Bignum specialization anymore.

    @eregon
    eregon committed Dec 2, 2014
    Copy the full SHA
    b083103 View commit details
Showing with 1 addition and 10 deletions.
  1. +1 −10 core/src/main/java/org/jruby/truffle/nodes/cast/BooleanCastNode.java
11 changes: 1 addition & 10 deletions core/src/main/java/org/jruby/truffle/nodes/cast/BooleanCastNode.java
View file
Original file line number Diff line number Diff line change
@@ -52,25 +52,16 @@ public boolean doLongFixnum(long value) {
return true;
}

@Specialization
public boolean doBignum(RubyBignum value) {
return true;
}

@Specialization
public boolean doFloat(double value) {
return true;
}

@Specialization(guards = "neitherNilNorFalse")
@Specialization(guards = "!isNil")
public boolean doBasicObject(RubyBasicObject object) {
return true;
}

protected boolean neitherNilNorFalse(RubyBasicObject object) {
return object != getContext().getCoreLibrary().getNilObject();
}

@Override
public abstract boolean executeBoolean(VirtualFrame frame);