Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to the APIs in the "author" folder. #9

Closed
wants to merge 11 commits into from

Conversation

Talina06
Copy link
Contributor

@oalders : These are my final changes.

  1. Made only to the author folder in this pull request.

size => 5,
},
);
my $search = $mc->author({name => 'Olaf *'});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oalders : Could you check this script?
I was unable to understand the logic to display all authors using MetaCPAN::Client, and could retrieve details for just a single author.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickeyn I just had a quick look at MetaCPAN::Client and it's also not clear to me if it's possible to get a resultset of every author in the Author type. How would we go about doing something like "query => { match_all => {} }" for authors?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oalders it's on my to-do list to investigate the replacement of the query building we do with match_all and filters.
i'll open an issue on mcpan::client to make that clear.
thanks for the reminder.

@@ -5,25 +5,16 @@
use feature qw( say );

use Data::Printer;
use MetaCPAN::API;
use MetaCPAN::Client;
use Search::Elasticsearch::Scroll;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we actually using this module?

@Talina06 Talina06 closed this Jun 11, 2014
@Talina06 Talina06 deleted the talina/authors branch June 11, 2014 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants